Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to properly copy-paste logs from StreamView #290

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

Alterrien
Copy link
Contributor

This PR changes two things on the StreamView. component of the frontend app, to allow to copy-paste several lines of log properly;

  • Puts the timestamps as user-select: none to disable the possibity to highlight it
  • Changes the paragraph tag to a more general div one, to stop inserting newlines when selecting log lines and pasting them

I tested it on Firefox 61, Chrome 67 and Safari 11.1.1, on macOS 10.13.5.

@haveo haveo merged commit 5b6de14 into criteo:master Jul 16, 2018
@Masuzu Masuzu mentioned this pull request Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants