Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GET /version endpoint to rest API #266

Merged
merged 3 commits into from
Apr 5, 2018
Merged

Add GET /version endpoint to rest API #266

merged 3 commits into from
Apr 5, 2018

Conversation

Masuzu
Copy link
Contributor

@Masuzu Masuzu commented Apr 5, 2018

No description provided.

loicknuchel
loicknuchel previously requested changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@loicknuchel loicknuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we really want to add and maintain multiple ways to get the same information

@vguerci vguerci dismissed loicknuchel’s stale review April 5, 2018 11:40

let's merge this :)

vguerci
vguerci suggested changes Apr 5, 2018
View reviewed changes
Copy link
Contributor

@vguerci vguerci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to put this in public api

@vguerci
Copy link
Contributor

vguerci commented Apr 5, 2018

Live coding in gh editor ftw ;p

@vguerci vguerci merged commit 11ee0a4 into criteo:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vguerci vguerci vguerci approved these changes

@loicknuchel loicknuchel loicknuchel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Masuzu @vguerci @loicknuchel @dufrannea