Add the endpoint /api/metrics for Prometheus. #175
Conversation
| case class Gauge(name: String, value: Long, tags: Seq[(String, String)] = Seq.empty) extends Metric | ||
|
|
||
| trait MetricProvider { | ||
| private[cuttle] def getMetrics(jobs: Set[String]): Seq[Metric] |
There was a problem hiding this comment.
Can't be private[cuttle] if it is exposed as part of the Scheduler API.
| @@ -0,0 +1,22 @@ | |||
| package com.criteo.cuttle | |||
There was a problem hiding this comment.
Can we scope all this into a Metrics object, so in the public API it's all coherent?
| private[cuttle] def getMetrics(jobs: Set[String]): Seq[Metric] | ||
| } | ||
|
|
||
| object Prometheus { |
There was a problem hiding this comment.
This one should be private[cuttle] as it is an implementation detail.
|
Corrected |
| @@ -378,6 +377,32 @@ class Executor[S <: Scheduling] private[cuttle] ( | |||
| limit: Int): Seq[ExecutionLog] = | |||
| queries.getExecutionLog(queryContexts, jobs, sort, asc, offset, limit).transact(xa).unsafePerformIO | |||
|
|
|||
| private[cuttle] def getStats(jobs: Set[String]): Json = { | |||
| val (running, waiting) = runningExecutionsSizes(jobs) | |||
There was a problem hiding this comment.
I just wanted to point out that provided figures can be inconsistent because stm accesses are non enclosed in a single
transaction. Not use this is critical though
| @@ -133,6 +133,10 @@ private[timeseries] object IntervalMap { | |||
| m <- this.intersect(interval).toList | |||
| } yield m): _*)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You are adding code you do not use, If you really feel this is something that needs to be done I would suggest you could move it to another PR.
| @@ -162,4 +166,6 @@ private[timeseries] sealed trait IntervalMap[A, B] { | |||
| def mapKeys[K: Ordering](f: A => K): IntervalMap[K, B] | |||
| def whenIsDef[C](other: IntervalMap[A, C]): IntervalMap[A, B] | |||
| def whenIsUndef[C](other: IntervalMap[A, C]): IntervalMap[A, B] | |||
| def head: (Interval[A], B) | |||
|
@dufrannea All done |
Add the endpoint /api/metrics for Prometheus.
Delete a logging package.
Small refactoring in Executor.scala.