Better cancel listener design #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumebort
force-pushed
the
guillaume/cancelLeak
branch
2 times, most recently
from
7b40a7d to
b1a5c4b
Compare
dufrannea
reviewed
Sep 20, 2017
| streams.debug(s"Execution has been cancelled by user ${user.userId}.") | ||
| true | ||
| } else false | ||
| listeners.foreach(_.thunk()) |
There was a problem hiding this comment.
Just curious if a thunk fails should the other be triggered ?
dufrannea
approved these changes
Sep 20, 2017
To avoid memory leak for long execution registering several cancel listeners, we now allow to unsubscribe when the code is not anymore interested by the cancel signal.
guillaumebort
force-pushed
the
guillaume/cancelLeak
branch
from
b1a5c4b to
b29a9fc
Compare
haveo
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid memory leak for long execution registering several cancel listeners,
we now allow to unsubscribe when the code is not anymore interested by the cancel
signal.