Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order in calendar focus (keep the topological sort) #121

Merged
merged 1 commit into from
Jul 13, 2017
Merged

Fix order in calendar focus (keep the topological sort) #121

merged 1 commit into from
Jul 13, 2017

Conversation

hhalex
Copy link
Contributor

@hhalex hhalex commented Jul 12, 2017

No description provided.

guillaumebort
guillaumebort suggested changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@guillaumebort guillaumebort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another regression here:

cuttle/core/src/main/javascript/app/pages/CalendarFocus.js

Line 170 in 7d89c31

showExecutions(jobName, moment.utc(period.start), moment.utc(period.end))

job id should be used to construct the URL, not job name.

@hhalex hhalex force-pushed the hhalex-fix-jobs-order-calendar-focus branch from 7d89c31 to f298206 Compare July 13, 2017 09:18
@guillaumebort guillaumebort merged commit 4ffd3b4 into master Jul 13, 2017
@guillaumebort guillaumebort deleted the hhalex-fix-jobs-order-calendar-focus branch July 13, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumebort guillaumebort guillaumebort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhalex @guillaumebort