Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscan index issue on tasks health #64

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

jbkt
Copy link

@jbkt jbkt commented Feb 14, 2023

As it was very slow with several thousands of tasks/instances, this uses two indexes instead.

@Lqp1 Lqp1 requested a review from a team February 14, 2023 15:44
@jbkt jbkt force-pushed the criteo/1.9.109-health-perf branch from 6b33d9f to b64f662 Compare February 14, 2023 16:20
Copy link

@Lqp1 Lqp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPT: Overall, should we have a test for theses classes? even if those are simple tests?

@jbkt jbkt force-pushed the criteo/1.9.109-health-perf branch 2 times, most recently from cd6af78 to 8609866 Compare February 20, 2023 19:04
As it was very slow with several thousands of tasks/instances, this uses two indexes instead.
@jbkt jbkt force-pushed the criteo/1.9.109-health-perf branch from 8609866 to 6017a1d Compare February 21, 2023 10:31
Copy link

@Lqp1 Lqp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll do a non-reg test and also will validate in preprod before merging

@Lqp1 Lqp1 merged commit 02137d3 into criteo-forks:criteo/1.9.109 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants