Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip parsing and formatting custom CSS properties #424

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

realStandal
Copy link
Contributor

@realStandal realStandal commented Jan 19, 2022

Untested

Closes #423

Skips formatting custom CSS properties using a lax check that a property's key does not begin with --.

@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cristianbote/goober-rocks/412qkvrbwnKbfQ3DZ1mQoGFHTSJX
✅ Preview: https://goober-rocks-git-fork-realstandal-master-cristianbote.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7a2217f:

Sandbox Source
Vanilla Configuration

@realStandal
Copy link
Contributor Author

realStandal commented Jan 19, 2022

I've redone the checking to exclude replacing CSS variables so old tests pass, and have included some new ones.

I'm not sure of the consequences of parsing the variables, but it hasn't caused me a problem with simple values 🤷‍♀️

Copy link
Contributor

@ksenginew ksenginew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shaved some bytes for you.

src/core/parse.js Outdated Show resolved Hide resolved
Co-authored-by: Kavindu Santhusa <[email protected]>
@cristianbote
Copy link
Owner

Thank you @realStandal and @ksenginew!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom CSS properties are manipulated from camel to kabab casing
3 participants