Skip to content

Commit

Permalink
fix(material/radio): clear names from host nodes
Browse files Browse the repository at this point in the history
Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.
  • Loading branch information
crisbeto committed Aug 23, 2022
1 parent 5ab25d0 commit fe0f0e8
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/material/legacy-radio/radio.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ describe('MatRadio', () => {
}
});

it('should clear the name attribute from the radio group host node', () => {
expect(groupInstance.name).toBeTruthy();
expect(groupDebugElement.nativeElement.getAttribute('name')).toBeFalsy();
});

it('should coerce the disabled binding on the radio group', () => {
(groupInstance as any).disabled = '';
fixture.detectChanges();
Expand Down
1 change: 1 addition & 0 deletions src/material/legacy-radio/radio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export class MatLegacyRadioGroup extends _MatRadioGroupBase<MatLegacyRadioButton
'[attr.aria-label]': 'null',
'[attr.aria-labelledby]': 'null',
'[attr.aria-describedby]': 'null',
'[attr.name]': 'null',
// Note: under normal conditions focus shouldn't land on this element, however it may be
// programmatically set, for example inside of a focus trap, in this case we want to forward
// the focus to the native element.
Expand Down
9 changes: 9 additions & 0 deletions src/material/radio/radio.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ describe('MDC-based MatRadio', () => {
}
});

it('should clear the name attribute from the radio group host node', () => {
expect(groupInstance.name).toBeTruthy();
expect(groupDebugElement.nativeElement.getAttribute('name')).toBeFalsy();
});

it('should coerce the disabled binding on the radio group', () => {
(groupInstance as any).disabled = '';
fixture.detectChanges();
Expand Down Expand Up @@ -821,6 +826,10 @@ describe('MDC-based MatRadio', () => {
it('should default the radio color to `accent`', () => {
expect(seasonRadioInstances.every(radio => radio.color === 'accent')).toBe(true);
});

it('should clear the name attribute from the radio host node', () => {
expect(radioDebugElements.every(el => !el.nativeElement.getAttribute('name'))).toBe(true);
});
});

describe('with tabindex', () => {
Expand Down
1 change: 1 addition & 0 deletions src/material/radio/radio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,7 @@ export class MatRadioGroup extends _MatRadioGroupBase<MatRadioButton> {
'[attr.aria-label]': 'null',
'[attr.aria-labelledby]': 'null',
'[attr.aria-describedby]': 'null',
'[attr.name]': 'null',
// Note: under normal conditions focus shouldn't land on this element, however it may be
// programmatically set, for example inside of a focus trap, in this case we want to forward
// the focus to the native element.
Expand Down

0 comments on commit fe0f0e8

Please sign in to comment.