fix(material/select): disabled state out of sync when swapping form g…

…roup with a disabled one

Fixes the disabled state of a `mat-select` falling out of sync with its form control if the
control's group is swapped out with one that is disabled on init.

Fixes angular#17860.

src/material-experimental/mdc-select/select.spec.ts

@@ -42,6 +42,7 @@ import {
 } from '@angular/core/testing';
 import {
   ControlValueAccessor,
+  FormBuilder,
   FormControl,
   FormGroup,
   FormGroupDirective,
@@ -1985,6 +1986,20 @@ describe('MDC-based MatSelect', () => {
         expect(fixture.componentInstance.select.panelOpen)
             .toBe(true, `Expected select panelOpen property to become true.`);
       }));
+
+      it('should keep the disabled state in sync if the form group is swapped and ' +
+        'disabled at the same time', fakeAsync(() => {
+          const fixture = TestBed.createComponent(SelectInsideDynamicFormGroup);
+          const instance = fixture.componentInstance;
+          fixture.detectChanges();
+
+          expect(instance.select.disabled).toBe(false);
+
+          instance.assignGroup(true);
+          fixture.detectChanges();
+
+          expect(instance.select.disabled).toBe(true);
+        }));
     });
 
     describe('keyboard scrolling', () => {
@@ -4608,3 +4623,30 @@ class SelectWithResetOptionAndFormControl {
   `
 })
 class SelectInNgContainer {}
+
+
+@Component({
+  template: `
+    <form [formGroup]="form">
+      <mat-form-field>
+        <mat-select formControlName="control">
+          <mat-option value="1">One</mat-option>
+        </mat-select>
+      </mat-form-field>
+    </form>
+  `
+})
+class SelectInsideDynamicFormGroup {
+  @ViewChild(MatSelect) select: MatSelect;
+  form: FormGroup;
+
+  constructor(private _formBuilder: FormBuilder) {
+    this.assignGroup(false);
+  }
+
+  assignGroup(isDisabled: boolean) {
+    this.form = this._formBuilder.group({
+      control: {value: '', disabled: isDisabled}
+    });
+  }
+}

src/material/select/select.spec.ts

@@ -50,6 +50,7 @@ import {
   NG_VALUE_ACCESSOR,
   ReactiveFormsModule,
   Validators,
+  FormBuilder,
 } from '@angular/forms';
 import {
   ErrorStateMatcher,
@@ -133,6 +134,7 @@ describe('MatSelect', () => {
         SelectWithGroupsAndNgContainer,
         SelectWithFormFieldLabel,
         SelectWithChangeEvent,
+        SelectInsideDynamicFormGroup,
       ]);
     }));
 
@@ -1999,6 +2001,20 @@ describe('MatSelect', () => {
         expect(fixture.componentInstance.select.panelOpen)
             .toBe(true, `Expected select panelOpen property to become true.`);
       }));
+
+      it('should keep the disabled state in sync if the form group is swapped and ' +
+        'disabled at the same time', fakeAsync(() => {
+          const fixture = TestBed.createComponent(SelectInsideDynamicFormGroup);
+          const instance = fixture.componentInstance;
+          fixture.detectChanges();
+
+          expect(instance.select.disabled).toBe(false);
+
+          instance.assignGroup(true);
+          fixture.detectChanges();
+
+          expect(instance.select.disabled).toBe(true);
+        }));
     });
 
     describe('animations', () => {
@@ -5507,3 +5523,29 @@ class SelectWithResetOptionAndFormControl {
   `
 })
 class SelectInNgContainer {}
+
+@Component({
+  template: `
+    <form [formGroup]="form">
+      <mat-form-field>
+        <mat-select formControlName="control">
+          <mat-option value="1">One</mat-option>
+        </mat-select>
+      </mat-form-field>
+    </form>
+  `
+})
+class SelectInsideDynamicFormGroup {
+  @ViewChild(MatSelect) select: MatSelect;
+  form: FormGroup;
+
+  constructor(private _formBuilder: FormBuilder) {
+    this.assignGroup(false);
+  }
+
+  assignGroup(isDisabled: boolean) {
+    this.form = this._formBuilder.group({
+      control: {value: '', disabled: isDisabled}
+    });
+  }
+}

src/material/select/select.ts

@@ -555,6 +555,11 @@ export abstract class _MatSelectBase<C> extends _MatSelectMixinBase implements A
     }
 
     if (this.ngControl) {
+      // The disabled state might go out of sync if the form group is swapped out. See #17860.
+      if (this.ngControl.disabled !== this.disabled) {
+        this.disabled = !!this.ngControl.disabled;
+      }
+
       this.updateErrorState();
     }
   }