Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow get_sane_name check for process/service ID to be shorter to accommodate existing WPS servers #559

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

fmigneault
Copy link
Collaborator

Fixes

  • Fix get_sane_name checks performed on Process ID and Service name to use min_len=1 in order to allow
    valid WPS process definition on existing servers to resolve references that are shorter than the previous default
    of 3 characters.

@fmigneault fmigneault self-assigned this Sep 13, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/providers Issue related to providers convertion to WPS-REST processes. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #559 (7895a8d) into master (dd99a64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          79       79           
  Lines       17641    17642    +1     
  Branches     2675     2675           
=======================================
+ Hits        14895    14896    +1     
  Misses       2019     2019           
  Partials      727      727           
Files Changed Coverage Δ
weaver/processes/utils.py 79.77% <100.00%> (ø)
weaver/processes/wps_package.py 84.05% <100.00%> (ø)
weaver/store/mongodb.py 78.38% <100.00%> (+0.03%) ⬆️

@fmigneault fmigneault merged commit 05a9ac2 into master Sep 13, 2023
47 checks passed
@fmigneault fmigneault deleted the fix-sane-name-check branch September 13, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/providers Issue related to providers convertion to WPS-REST processes. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant