Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid literal data numerics conversion and validation between WPS/OAS/CWL representations #558

Merged
merged 13 commits into from
Sep 13, 2023

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Sep 9, 2023

Fixes

To Do

  • apply InlineJavascriptRequirement automatically if missing when valueFrom is added for input validation of numerics
  • add tests to validate conversion from WPS -> CWL
  • add tests running CWL with invalid int/float/bool/other values against input generated with valueFrom validation

@fmigneault fmigneault self-assigned this Sep 9, 2023
@fmigneault fmigneault changed the title fix invalid literal data numerics conversion and validation between WPS, OAS, CWL representations fix invalid literal data numerics conversion and validation between WPS/OAS/CWL representations Sep 9, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/oas Issues related to OpenAPI specifications. feature/db Related to database or datatype manipulation. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Sep 9, 2023
@fmigneault fmigneault added process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support and removed ci/tests Tests of the package and features ci/doc Issue related to documentation of the package feature/db Related to database or datatype manipulation. ci/operations Related to CI operations (actions, execution, install, builds, etc.) feature/cli Issues or features related to CLI operations. labels Sep 9, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. labels Sep 9, 2023
@github-actions github-actions bot added the feature/db Related to database or datatype manipulation. label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #558 (abe66fe) into master (dd99a64) will increase coverage by 0.02%.
The diff coverage is 92.10%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   84.43%   84.45%   +0.02%     
==========================================
  Files          79       79              
  Lines       17641    17702      +61     
  Branches     2675     2685      +10     
==========================================
+ Hits        14895    14951      +56     
- Misses       2019     2022       +3     
- Partials      727      729       +2     
Files Changed Coverage Δ
weaver/processes/convert.py 84.18% <86.15%> (+0.10%) ⬆️
weaver/database/base.py 85.71% <100.00%> (ø)
weaver/processes/constants.py 100.00% <100.00%> (ø)
weaver/processes/wps_package.py 84.05% <100.00%> (ø)
weaver/processes/wps_testing.py 88.00% <100.00%> (ø)
weaver/store/base.py 100.00% <100.00%> (ø)
weaver/wps_restapi/swagger_definitions.py 99.82% <100.00%> (ø)

@fmigneault fmigneault merged commit bcbb2ec into master Sep 13, 2023
23 of 25 checks passed
@fmigneault fmigneault deleted the fix-cwl-enum branch September 13, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/operations Related to CI operations (actions, execution, install, builds, etc.) ci/tests Tests of the package and features feature/cli Issues or features related to CLI operations. feature/CWL Issue related to CWL support feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant