-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix invalid literal data numerics conversion and validation between WPS/OAS/CWL representations #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes (missing InlineJavascriptRequirement insertion)
fmigneault
changed the title
fix invalid literal data numerics conversion and validation between WPS, OAS, CWL representations
fix invalid literal data numerics conversion and validation between WPS/OAS/CWL representations
Sep 9, 2023
github-actions
bot
added
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/oas
Issues related to OpenAPI specifications.
feature/db
Related to database or datatype manipulation.
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
labels
Sep 9, 2023
fmigneault
added
process/wps1
Issue related to WPS 1.x processes support
process/wps2
Issue related to WPS 2.x processes support
and removed
ci/tests
Tests of the package and features
ci/doc
Issue related to documentation of the package
feature/db
Related to database or datatype manipulation.
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
feature/cli
Issues or features related to CLI operations.
labels
Sep 9, 2023
github-actions
bot
added
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
labels
Sep 9, 2023
github-actions
bot
added
the
feature/db
Related to database or datatype manipulation.
label
Sep 11, 2023
…eudo enum validation
…idation using JS valueFrom
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 84.43% 84.45% +0.02%
==========================================
Files 79 79
Lines 17641 17702 +61
Branches 2675 2685 +10
==========================================
+ Hits 14895 14951 +56
- Misses 2019 2022 +3
- Partials 727 729 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/cli
Issues or features related to CLI operations.
feature/CWL
Issue related to CWL support
feature/db
Related to database or datatype manipulation.
feature/oas
Issues related to OpenAPI specifications.
process/wps1
Issue related to WPS 1.x processes support
process/wps2
Issue related to WPS 2.x processes support
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
OpenAPI
schema link references toOGC API - Processes
repository.WPS
I/Ointeger
literal data conversion toOpenAPI
I/Oschema
definition injecting aninvalid
format: double
property due to type checking withfloat
succeeding againstint
values.CWL
I/O value validation forenum
-like definitions from correspondingOpenAPI
andWPS
I/O.Since
CWL
I/O do not allowEnum
type for values other than basicstring
type,valueFrom
attribute isused to handle
int
,float
andbool
types, using an embedded JavaScript validation against allowed values.Because of this validation strategy,
CWL
packages must now includeInlineJavascriptRequirement
when allowedvalues for these basic types must be performed in order for the
CWL
engine to parse I/O contents ofvalueFrom
(relates to CWL Enum using numerics ? common-workflow-language/cwl-v1.2#267, input value restrictions / validations common-workflow-language/common-workflow-language#764 and How to specify lower and upper bound for type
array
in WorkflowInputParameter common-workflow-language/common-workflow-language#907).Literal
references for proper resolution involving values stored in constants.To Do
InlineJavascriptRequirement
automatically if missing whenvalueFrom
is added for input validation of numericsvalueFrom
validation