Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix schema validation prohibiting job execution with empty string input #554

Merged
merged 7 commits into from
Sep 8, 2023

Conversation

fmigneault
Copy link
Collaborator

Fixes

  • Fix Job creation failing when submitting an empty string as input for a Process that allows it due
    to schema validation incorrectly preventing it.

@fmigneault fmigneault requested a review from perronld September 5, 2023 20:26
@fmigneault fmigneault self-assigned this Sep 5, 2023
@github-actions github-actions bot added ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/oas Issues related to OpenAPI specifications. process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support feature/db Related to database or datatype manipulation. process/wps3 Issue related to WPS 3.x (REST-JSON) processes support labels Sep 5, 2023
perronld
perronld previously approved these changes Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #554 (97e800c) into master (f7be768) will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          79       79           
  Lines       17637    17641    +4     
  Branches     2674     2675    +1     
=======================================
+ Hits        14891    14895    +4     
  Misses       2019     2019           
  Partials      727      727           
Files Changed Coverage Δ
weaver/utils.py 82.85% <88.88%> (-0.01%) ⬇️
weaver/processes/convert.py 84.07% <100.00%> (+0.05%) ⬆️
weaver/wps_restapi/swagger_definitions.py 99.82% <100.00%> (ø)

@fmigneault fmigneault merged commit ce06256 into master Sep 8, 2023
47 checks passed
@fmigneault fmigneault deleted the fix-empty-input-string branch September 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/doc Issue related to documentation of the package ci/tests Tests of the package and features feature/db Related to database or datatype manipulation. feature/oas Issues related to OpenAPI specifications. process/wps1 Issue related to WPS 1.x processes support process/wps2 Issue related to WPS 2.x processes support process/wps3 Issue related to WPS 3.x (REST-JSON) processes support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants