Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support embedded step definition in CWL #56

Open
matprov opened this issue Dec 20, 2019 · 4 comments
Open

Support embedded step definition in CWL #56

matprov opened this issue Dec 20, 2019 · 4 comments
Labels
feature/CWL Issue related to CWL support triage/feature New requested feature. triage/investigate Exploration tasks or issues requirering more analysis

Comments

@matprov
Copy link

matprov commented Dec 20, 2019

It is not currently possible to embed steps in a CWL workflow definition in weaver.
According to the CWL spec, it is possible to have step definitions in the workflow itself.
@fmigneault fmigneault added feature/CWL Issue related to CWL support triage/feature New requested feature. labels Dec 20, 2019
@fmigneault
Copy link
Collaborator

This is a bit tricky because in our situation, we usually want each step to refer to an existing/deployed process in the EMS's catalogue.
I'm not sure if there are any real use cases where to process definition is simple enough to be only defined embedded instead of having a complete/detailed process definition, and probably if there are, they should be considered to be ported to builtin processes.

@fmigneault fmigneault added the triage/investigate Exploration tasks or issues requirering more analysis label Apr 22, 2020
@fmigneault
Copy link
Collaborator

This kind of use case must be described in #61

fmigneault added a commit that referenced this issue Jun 8, 2020
@fmigneault
add cwl workflow details and example + note regarding embedded steps (#…
744ba4f 
…56)
@fmigneault
Copy link
Collaborator

fmigneault commented Mar 24, 2022 •
edited
Loading

More details about expected behaviour defined in Best Practices: https://docs.ogc.org/bp/20-089r1.html#toc28

Allow definition of a $graph which is a list of Workflow + one or more CommandLineTool all together.
The Workflow refers to the step CommandLineTool using their id.

See also: https://www.commonwl.org/v1.2/CommandLineTool.html#Packed_documents

fmigneault added a commit that referenced this issue Mar 24, 2022
@fmigneault
conformance api can return references by category + add CWL / OGC-Bes…
3388b78 
…t-Practices EO App Pkg conformance items (relates to #56, #103, #105, #294, #399)
@fmigneault fmigneault mentioned this issue Mar 24, 2022
Merged
fmigneault added a commit that referenced this issue Jun 9, 2022
@fmigneault
partial support of CWL for single app process (relates to #56)
64df036
@fmigneault
Copy link
Collaborator

fmigneault commented Nov 3, 2023 •
edited
Loading

@fmigneault fmigneault mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/CWL Issue related to CWL support triage/feature New requested feature. triage/investigate Exploration tasks or issues requirering more analysis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matprov @fmigneault