Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arch finalization proposal #25
Arch finalization proposal #25
Changes from 7 commits
71ce3e0
350b4f4
2a445f0
2728ce6
b47d613
2f5dc39
3f821ce
3c584cc
b7a7ed9
48598ae
94eb521
a64a226
f22c1a2
efd9230
3e88591
8d66fba
00a968a
2c3b49d
6908d55
0c959ea
73b2773
9e919c2
c62fb80
10db128
25985db
6d675bc
65bd5bb
f540dbe
323c945
0581c61
37a26e1
e55591d
f1e28db
8bb21e1
3055afc
3f1d284
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this gets lost after conversion?
At the very least, the converted STAC Item should contain the
rel: source
withhref
point at the original NetCDF file and therel: describes
withhref
pointing at the NCML. In the case ofrel: source
, it is also very important thattitle
contains the "path" of the file without the THREDDS URL prefix and the "service" path element (dodsC, fileServer, etc.).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't quite understand your point. The access URLs are contained as assets to the item. This is code that David had but it didn't look like it was being used, so I left it there but commented it out.
@huard would you like to pitch in here with a description of what you were doing and if that was complete? Also, how we can include Francis's suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the STAC Item is created (POST'd to the API), some resources in Magpie are generated under the
stac
service to manage its permissions.Since that item refers to a NetCDF under THREDDS, a corresponding resource exists under
thredds
service to manage its permissions as well.Using bird-house/birdhouse-deploy#386, the intent is that when a permission is updated on one, it will synchronize with the other, such that viewing the NetCDF metadata from either service is allowed/denied in the same way for a given user or group.
The problem in doing the above is that the URLs of these 2 services are not "compatible".
The generated resources would be nested like so (for simplicity, I omit the nested-directory handling below) :
Since one works with UUIDs and the other with path names, there is no direct way to guess the references only from the URLs. Therefore, the STAC hook will use one of the references in
links
, namely therel: source
one, to obtain the STAC Asset URL of the original THREDDS NetCDF location. To establish the "link" between thestac
andthredds
Magpie services, it will use thetitle
value from therel: source
link to establish aresource_display_name
in Magpie. That parameter will be readable from Cowbird later on to resolve thestac
UUID <->thredds
name resource relationship.For example, the following catalog reference:
https://pavics.ouranos.ca/twitcher/ows/proxy/thredds/catalog/birdhouse/testdata/xclim/cmip6/catalog.html?dataset=birdhouse/testdata/xclim/cmip6/sic_SImon_CCCma-CanESM5_ssp245_r13i1p2f1_2020.nc
Should have (at least) the following link in the STAC Item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that explanation @fmigneault. This makes sense. Let me implement this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay done. If all looks good then I will complete the merge.