-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reuse the already loaded repositories #252
Don't reuse the already loaded repositories #252
Conversation
@davesmits thanks for raising this PR, I will try to look into it in the following days. It's breaking the build due the invalid variable declaration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's breaking the build, I will look into this in the following days
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@cribeiro84 want to give it another look? should be building now again |
@cribeiro84 anything I can to do to get this merged or fixed? |
Quality Gate passedIssues Measures |
was this tested on your environment? Did you see any impact? |
I will give it a renew try this weekend. not sure where I left it off. |
An attempt to get #241 fixed
I noticed two faulty behaviors:
This change should reset the items in the state instead of just keep adding more and more
DISCLAIMER:
So far not been able to test it locally.. which makes it a bit of a risky change. Maybe a maintainer can give me a hand?