Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cni to 0.8.0 #79

Merged
merged 3 commits into from
Oct 28, 2020
Merged

bump cni to 0.8.0 #79

merged 3 commits into from
Oct 28, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Sep 7, 2020

Update CNI and CNI plugins to the latest stable release.

I've also noticed that some modules were not vendored in the repo.
Don't know if that was done on purpose, so I've added them in different commits

golang.org/x/sys/unix
github.com/vishvananda/netlink
github.com/vishvananda/ns

Signed-off-by: Antonio Ojea [email protected]

None

Antonio Ojea added 3 commits September 7, 2020 15:54
Signed-off-by: Antonio Ojea <[email protected]>
Signed-off-by: Antonio Ojea <[email protected]>
Signed-off-by: Antonio Ojea <[email protected]>
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2020
@aojea
Copy link
Contributor Author

aojea commented Sep 7, 2020

/assign @mrunalp @saschagrunert
/cc @dcbw

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haircommander
Copy link
Member

LGTM

@mrunalp @dcbw PTAL

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@mrunalp
Copy link
Member

mrunalp commented Sep 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 10, 2020
@aojea
Copy link
Contributor Author

aojea commented Oct 27, 2020

hey folks, just checking in here, what is missing?
@saschagrunert @mrunalp

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I guess that's the only thing missing here…

@saschagrunert
Copy link
Member

/assign @mrunalp
Lacking power…

@mrunalp
Copy link
Member

mrunalp commented Oct 28, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4841092 into cri-o:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants