Indexing of FMap in logic
#1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgolfouse
force-pushed
the
fmap-index-logic
branch
from
918d88a
to
09d203d
Compare
xldenis
reviewed
Nov 26, 2024
creusot-contracts/src/logic/fmap.rs
Outdated
| #[trusted] | ||
| #[logic] | ||
| #[ensures(result.len() == 0)] | ||
| #[ensures(result.view() == Mapping::cst(None))] | ||
| pub fn empty() -> Self { | ||
| pub fn create() -> Self { |
There was a problem hiding this comment.
Since this is logic not ghost I'm not sure create is really the write name, all empty sets should be the same, there is no other notion of identity right?
There was a problem hiding this comment.
Maybe not, I was primarily aiming for consistency between Seq/FMap/FSet. We could have both an empty creation method and an EMPTY constant for the three of them, how does that sound?
There was a problem hiding this comment.
I would prefer that over create. create implies something fresh to me so the fact that they are all the same unit element of their type would suggest a different name.
arnaudgolfouse
force-pushed
the
fmap-index-logic
branch
from
09d203d
to
185a46d
Compare
This makes it more consistent to create data structure in pearlite.
arnaudgolfouse
force-pushed
the
fmap-index-logic
branch
from
185a46d
to
05b4792
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow indexing of a
FMapin logic. It only works withSizedvalues though.Also add
FMap::createandFSet::createfor consistency withSeq.