Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve PoolResponse from gGRPC queries #335 #46

Merged
merged 4 commits into from
Jul 13, 2022
Merged

feat: improve PoolResponse from gGRPC queries #335 #46

merged 4 commits into from
Jul 13, 2022

Conversation

kingcre
Copy link
Contributor

@kingcre kingcre commented Jul 13, 2022

Description

Tasks

References

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

hallazzang and others added 4 commits July 13, 2022 19:57
@hallazzang @kingcre
feat: improve PoolResponse from gGRPC queries (cherry-picked)
5914d30 
- add `base_coin` and `quote_coin` fields under `balances`
- add `price` field which is `null` for disabled pools
- add `pool_coin_supply` field

(cherry picked from commit 49d4a4a)
@kingcre
fix: update client docs and write CHANGELOG (cherry-picked)
b2f801d 
(cherry picked from commit 567978c)
@kingcre
fix: apply code review suggestion (cherry-picked)
7156a62 
(cherry picked from commit 9b3f013)
@kingcre
chore: fix CHANGELOG (cherry-picked)
e9971cc 
(cherry picked from commit 454165f)
@kingcre kingcre requested review from crypin and queencre as code owners July 13, 2022 11:04
@kingcre kingcre self-assigned this Jul 13, 2022
@github-actions github-actions bot added documentation Improvements or additions to documentation x/liquidity labels Jul 13, 2022
@crypin crypin merged commit 710e3d4 into main Jul 13, 2022
@kingcre kingcre deleted the cherry-pick/335 branch August 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crypin crypin crypin approved these changes

@queencre queencre Awaiting requested review from queencre

Assignees

@kingcre kingcre

Labels
documentation Improvements or additions to documentation x/liquidity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingcre @crypin @hallazzang