fix: reviews for x/amm, x/exchange, x/liquidamm #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackhatcre
requested review from
crypin,
kingcre,
richard-bachman and
lv-koala
as code owners
kingcre
reviewed
Oct 11, 2023
| @@ -203,6 +203,8 @@ func (k Querier) RewardsAuction(c context.Context, req *types.QueryRewardsAuctio | |||
| } | |||
|
|
|||
| // Bids queries all Bid objects. | |||
| // In the kv store, there are only bids for auctions that are currently in progress. | |||
| // If req.AuctionId is not PublicPosition.LastRewardsAuctionId, the query is meaningless. | |||
There was a problem hiding this comment.
TODO: Rename this query to BestBid and add AllBestBids query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviews for x/amm, x/exchange and x/liquidamm modules
closes: #XXXX
Tasks
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes