Skip to content

Commit

Permalink
Try to align pasted images
Browse files Browse the repository at this point in the history
  • Loading branch information
@aljawaid
aljawaid committed Nov 4, 2022
1 parent 5fde3a0 commit d164eab
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions Template/printlayout/description.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
<div class="accordion-title">
<h3><a href="#" class="fa accordion-toggle"></a> <?= t('Description') ?></h3>
</div>
<style type="text/css">
img.enlargable {
max-width: 300px;
max-height: 300px;
cursor: zoom-in;
margin: 5px 10px;
display: inline-block !important;
}
</style>
<div class="accordion-content">
<article class="markdown">
<?= $this->text->markdown($this->task->printModel->codeblockFix($task['description']), isset($is_public) && $is_public) ?>
Expand Down

5 comments on commit d164eab

@aljawaid
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please upload this code to your test server? so i can check out the generated pdf?

@aljawaid
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creecros so the css (as far as i know with other applications I used) MUST be in the html file via <style> or it wont get included when generating.

In terms of styling, your print model is useless to me, I had a look at that. The above commit should technically work, same onscreen as pdf

@aljawaid
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@creecros oh i edited the test code myself, hang on let me see if it works

@aljawaid
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so your description img problem is sorted onscreen and pdf

@creecros
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aljawaid no worries, no rush on this, i've been trying to get this plugin sorted for like 4 years...the fact that I even got the images to load got me all excited!
but ya, just edit the code form the browser link i gave you, so you dont have to pull every edit in git. we can git push all the edits later.

Please sign in to comment.