Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Broken Version detection for Kanboard Nightly Builds #78

Closed
mundry opened this issue Mar 30, 2023 · 2 comments
Closed

Bug: Broken Version detection for Kanboard Nightly Builds #78

mundry opened this issue Mar 30, 2023 · 2 comments

Comments

@mundry
Copy link
Contributor

mundry commented Mar 30, 2023

Hi,

For development builds of Kanboard, where the APP_VERSION is main.<shortened git hash>, the version detection of this plugin relies on the ChangeLog file to infer the latest release version.
However, the ChangeLog has not been part of Docker builds since version 1.2.9 of Kanboard.

This breaks the version detection with Kanboard nightly Docker images, resulting in the wrong compatibility classes being loaded.

@creecros
Copy link
Owner

Might be time to stop supporting backward compatibility, or make it so it defaults to the latest code.

@creecros
Copy link
Owner

Ya, looks like my else statement is the old pre 1.2.5 code, cause I'm a dumb dumb, causing a greater chance to break, vs the 1 person in the world still using 1.2.4 and below with master version...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants