feat: Allow i64 to be represented as string in user code #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-greene-ck
requested review from
remi-thieblin-ck,
anusha-mallampati-ck,
a user and
ramakrishna-battala-ck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the "loose" representation of
i64to benumber | string | thrift.Int64. Previously this wasnumber | thrift.Int64.Because we can't confidently represent the full range of 64-bit integers in the JavaScript
numbertype (we'll explorebigintin the future) we have to use a wrapper typeInt64to maintain precision. Values that are generated in JS are very unlikely to actually need the full precision and can therefore be represented asnumberin user code. Another work around for users is to pass 64-bit integers asstring. In the generated code we can handle these conversions for the user and allow them to represent these numbers as makes sense to their app.