Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Injectable request #131

Merged

Conversation

nick-penaranda-ck
Copy link
Contributor

Description

Add an optional requestImpl to HttpConnection constructor to allow users to provide their own request implementation. By default, the normal request module will be used.

Motivation and Context

Allowing request to be injected is useful for various instrumentation tasks like adding/modifying headers, timing, and faciliating integrations that rely on wrapping request.

How Has This Been Tested?

A new test case was added to thrift-integration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nick-penaranda-ck nick-penaranda-ck changed the title Injectable request feat: Injectable request May 21, 2020
@ramakrishna-battala-ck ramakrishna-battala-ck merged commit 370a0c2 into creditkarma:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants