Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Handle credential requests #112

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Handle credential requests #112

merged 2 commits into from
Jan 30, 2020

Conversation

leonbotros
Copy link

This should fix #111. I'm new to Go/IRMA, so feedback is very much appreciated.

@leonbotros leonbotros requested a review from davidv1992 January 21, 2020 13:19
davidv1992
davidv1992 reviewed Jan 21, 2020
View reviewed changes
Copy link
Contributor

@davidv1992 davidv1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but for error handling, it is better to do early exit through a return in the if, and not have the normal flow following the error check in the else, but just at top level. If you can fix that that would be grand.

@leonbotros
Copy link
Author

Early* :)

@sietseringers sietseringers merged commit e8b56d2 into master Jan 30, 2020
@sietseringers sietseringers deleted the handle-credential-requests branch January 30, 2020 19:05
@leonbotros leonbotros mentioned this pull request Feb 19, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidv1992 davidv1992 davidv1992 left review comments

@sietseringers sietseringers sietseringers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when requesting credential
3 participants
@leonbotros @davidv1992 @sietseringers