Audit 2 remediation #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplodge-pro
reviewed
Jul 24, 2024
| @@ -25,11 +26,16 @@ contract CBLTest is Test { | |||
| cbl = deployCBLToken.runTest(); | |||
| } | |||
|
|
|||
| function test__CBL__ShouldRevertOnZeroAddress() public { | |||
| vm.expectRevert(CBL.CBL__ZeroAddress.selector); | |||
| new CBL(address(0), address(0), type(uint32).max); | |||
There was a problem hiding this comment.
- This single test case does not prove that ZeroAddress happens when both parameters are
address(0). It only proves it for the first one checked. - We changed our approach to have specific errors for zero address errors.
Pin OpenZeppellin to branch `release-v5.0`
lucasia
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hacken Findings: https://portal.hacken.io/App/Projects/Details/18cde808-e1f5-4d30-89e7-2acc006cd76a/Findings
Notion Internal Discussion: https://www.notion.so/Audit-findings-and-remediation-4d67681fecd242ab9efe51129bd06c61?pvs=4