Fix the ci-dev-app.yml Github Action/build.
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfig will need the CBL Token address at construct time
…nfig will need the CBL Token address at construct time
… using local instances.
… exist. Upgraded Turbo, Husky and lint-staged versions to latest Updated the Yarn Scripts to match the supported Turbo ones.
…ges (i.e. `clean` etc.)
Closed
Fix the
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
1 0 0 4 15 20 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
…kes the same thing as `build` instead of invoking `yarn build`
…ust invokes the same thing as `build` instead of invoking `yarn build`" This reverts commit c80f9e6.
Print out the env.
Removed debugging from the vercel build command. reduced the extent of the hack by only including the non-NEXT_PUBLIC_ variables in the `.env.local` file.
This reverts commit 1ad8a14.
Removed the sdk build from the `ci-dev-app.yml`.
lucasia
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Some oddness around module inter-dependency.
turbodoes not recognise that other modules depend onsdk. More investigations needed.Did
sdkand then build everything else.turbo,huskyandlint-staged(dependencies in root project).turboconfig to enforce some standard dependency-centric tasks across all the packages (e.g.clean,buildetc.)cleantasks per package).build:uitask tosdkso that theturbobuild dependency kicks in and buildssdkbeforeapp.NEXT_PUBLIC_environment variables into theapp/.env.localfile to be picked up and compiled into the project.spikesandscriptsas Yarn Workspaces, as they don't exist anymore.Conclusion
The issue is fixed, but via a hack is concerning.
Resolves #68