Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the Create Vault integration tests are working. #59

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

jplodge-pro
Copy link
Member

@jplodge-pro jplodge-pro commented Jun 18, 2024

  • Ensure the Create Vault tests for Fixed Yield With Upside Vaults are working.
  • Ensure the Create Vault tests for Vaults with Tenants are working.
  • Add helper function tests.

Secondarily...

  • Removed the unused abi.ts
  • Adopted the Schema implementation as per sdk (will move to shared package in the future).
  • Updated all scripts to use the Schema mechanism.
  • Updated the Schema in sdk to have readonly properties.
  • Normalised sdk and ops Playwright config.

packages/ops/src/utils/helpers.ts Outdated Show resolved Hide resolved
packages/ops/src/utils/schema.ts Show resolved Hide resolved
@jplodge-pro jplodge-pro marked this pull request as ready for review June 19, 2024 05:31
@jplodge-pro jplodge-pro merged commit c78b14f into main Jun 19, 2024
2 checks passed
@jplodge-pro jplodge-pro deleted the fix-create-vault-tests branch June 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants