Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"required" added to search input #288

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SisiVero
Copy link
Contributor

Fixes

Description

This PR addresses the issue of adding the required feature in the input tag to handle the case whereby if a user did input a value, he or she will be prompted to do so within the input field rather than having a JavaScript function for it. This makes the code dryer and enhances UX for all screens.

Tests

  1. The "required " feature was added to the search input to prompt users and tested.
  2. The initial JavaScript function for it was removed and the required feature still prompts user(s) when needed.

Screenshots

Below is the former popUp:
popUp

Below is the required feature in use:
required

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

@SisiVero SisiVero requested a review from a team as a code owner October 10, 2024 18:23
@SisiVero SisiVero requested review from TimidRobot and Shafiya-Heena and removed request for a team October 10, 2024 18:23
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit d5f5502
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/670f798d4f9f5200081c459d
😎 Deploy Preview https://deploy-preview-288--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SisiVero
Copy link
Contributor Author

SisiVero commented Oct 16, 2024

Hi @possumbilities , could you check this when you are free?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Bug] No "required" in search input
1 participant