Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] No Windows equivalent command for build-component in package.json #480

Open
1 task done
kartiksprajapati opened this issue Apr 2, 2023 · 3 comments
Open
1 task done
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work

Comments

@kartiksprajapati
Copy link

Description

I noticed that the package.json file in this repository contains a build-component command for Linux, but there doesn't seem to be a Windows equivalent command for it. This can be problematic for Windows users who need to build the component.

Reproduction

  1. Clone git repo and install all dependencies with npm install
  2. Run npm run build-component
  3. See error.

Expectation

I expect that the package.json file should contain a command that works on both Windows and Unix-based systems, or there should be clear instructions on how Windows users can build the component.

Screenshots

image

Environment

  • Device: Laptop
  • OS: Windows 11

Resolution

  • I would be interested in resolving this bug.
@kartiksprajapati kartiksprajapati added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Apr 2, 2023
@Pursottam6003
Copy link

Well Noticed! the page I guess we can update the build command using the following command

{
  "name": "my-component",
  "version": "1.0.0",
  "description": "My awesome component",
  "scripts": {
    "build-component": "npm run clean && webpack --config webpack.config.js",
    "clean": "rm -rf dist",
    "start": "webpack serve --config webpack.config.js"
  },
  "devDependencies": {
    "webpack": "^5.64.4",
    "webpack-cli": "^4.9.1"
  }
}


To run we can do this

npm run build-component

Nice work

Abhishek140501 added a commit to Abhishek140501/chooser that referenced this issue Jul 3, 2023
@dhruvgupta0503
Copy link

hi is this issue still open
I would like to work on this issue

@ayushdasgupta
Copy link

Is it still open?

@possumbilities possumbilities added 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be fixed soon 🏁 status: ready for work Ready for work
Projects
Status: Backlog
Development

No branches or pull requests

5 participants