Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Remove underline from links. Change "submit resource" and "See all" into <button> #135

Closed
Aditya-ahirwar opened this issue Mar 31, 2023 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on

Comments

@Aditya-ahirwar
Copy link

Problem

Links on the page have underlines which don't looks good. Also "submit resource" and "See all" should be button tags.

Description

Links on the page have underlines which make the page look crowded. We can remove these underlines to make the page look good.
"submit resource" and "See all" should be button tags to enhance user experience.

Implementation

  • [x ] I would be interested in implementing this feature.
@Aditya-ahirwar Aditya-ahirwar added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 31, 2023
@Ipshita02
Copy link

I think I can do this. please assign me

@possumbilities
Copy link
Contributor

Hi! Thank you for taking the time to write these, but generally links should have underlines to be adequately accessible. The "see all" is a link, which loads a new page. Buttons are for changing the state of an existing page in some way, links/anchors are for opening new pages so I'd say that it seems like both of these items aren't Issues at the moment. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed ⛔️ status: discarded Will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants