Merge branch '2' into 3

creative-commoners · Nov 26, 2024 · a22c5ca · a22c5ca
2 parents dbb0487 + 0c04234
commit a22c5ca
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/code/ModalController.php b/code/ModalController.php
@@ -22,9 +22,13 @@ class ModalController extends FormSchemaController
 
     /**
      * Builds and returns the external link form
+     *
+     * @return Form
+     * @deprecated 2.4.0 Will be replaced with linkModalForm()
      */
     public function EditorExternalLink(): Form
     {
+        Deprecation::noticeWithNoReplacment('2.4.0', 'Will be replaced with linkModalForm()');
         // Show link text field if requested
         $showLinkText = $this->getRequest()->getVar('requireLinkText');
         $factory = EditorExternalLinkFormFactory::singleton();
@@ -37,9 +41,13 @@ public function EditorExternalLink(): Form
 
     /**
      * Builds and returns the external link form
+     *
+     * @return Form
+     * @deprecated 2.4.0 Will be replaced with linkModalForm()
      */
     public function EditorEmailLink(): Form
     {
+        Deprecation::noticeWithNoReplacment('2.4.0', 'Will be replaced with linkModalForm()');
         // Show link text field if requested
         $showLinkText = $this->getRequest()->getVar('requireLinkText');
         $factory = EditorEmailLinkFormFactory::singleton();