Issue #838 Add virtualbox deprecation notice #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjannath
approved these changes
Nov 25, 2019
pkg/crc/machine/driver_windows.go
Outdated
| @@ -37,6 +38,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} { | |||
| switch machineConfig.VMDriver { | |||
|
|
|||
| case "virtualbox": | |||
| output.Outln("Virtualbox support is deprecated and will be removed in the next release.") | |||
There was a problem hiding this comment.
Instead of output.Outln I would use logging.Warn so that in the output it atleast show a warning to the user about this deprecation.
There was a problem hiding this comment.
I was considering this... If you think this is better, I'll change
|
Updated to use |
praveenkumar
approved these changes
Nov 25, 2019
| @@ -39,6 +40,7 @@ func getDriverOptions(machineConfig config.MachineConfig) interface{} { | |||
| switch machineConfig.VMDriver { | |||
|
|
|||
| case "virtualbox": | |||
| logging.Warn("Virtualbox support is deprecated and will be removed in the next release.") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838 Adds a deprecation notice when the vbox driver is used.