Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (status) : Log info in CRC status for OKD preset (#3626) #4479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

⚠️ This currently doesn't work as expected due to #4478

Fixes: Issue #3626

Relates to: Issue #3626

Solution/Idea

Currently, crc status logs information only for OpenShift and MicroShift presets. We should also log cluster information for the OKD preset.

Proposed changes

This PR only changes the way crc status logs information for okd preset.

Old behavior of crc status on OKD preset:

CRC VM:          Running
OpenShift:       Running (v4.15.0-0.okd-2024-02-23-163410)
RAM Usage:       647.2MB of 10.95GB
Disk Usage:      21.48GB of 32.68GB (Inside the CRC VM)
Cache Usage:     67.13GB
Cache Directory: /home/rokumar/.crc/cache

Expected New behavior of crc status on OKD preset:

CRC VM:          Running
OpenShift/OKD:       Running (v4.15.0-0.okd-2024-02-23-163410)
RAM Usage:       647.2MB of 10.95GB
Disk Usage:      21.48GB of 32.68GB (Inside the CRC VM)
Cache Usage:     67.13GB
Cache Directory: /home/rokumar/.crc/cache

Testing

  • Set up crc cluster
    • crc config set preset okd
    • crc setup
    • crc start
  • Run crc status (should see OpenShift/OKD in status logs)

Currently `crc status` only logs information for OpenShift and
MicroShift presets only. We should also log cluster information for OKD
preset.

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 22, 2024

Hi @rohanKanojia. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant