Add redirect to curl command in DNS check #4477
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -119,7 +119,7 @@ func CheckCRCPublicDNSReachable(serviceConfig services.ServicePostStartConfig) ( | |||
| // try without using proxy | |||
| proxyConfig = &httpproxy.ProxyConfig{} | |||
| } | |||
| curlArgs := []string{"--head", publicDNSQueryURI} | |||
| curlArgs := []string{"--head", publicDNSQueryURI, "-L"} | |||
There was a problem hiding this comment.
Follow is good, but I think it is better to do
curl -sSL
-S: This option is used in conjunction with -s (silent). It stands for "show error." When used with -s, it will still suppress the progress meter but will show error messages if the request fails. This could be beneficial for logging and debugging purposes since it reduces noise. It might even be possible to return the actual error as user-facing information. WDYT?
There was a problem hiding this comment.
97ee5fc#r1853762839 => Perhaps the error message can be helpful to the user.
Fixes: Issue #N
Relates to: Issue #N, PR #N, ...
Solution/Idea
Describe in plain English what you solved and how. For instance, Added
startcommand to CRC so the user can create a VM and set-up a single-node OpenShift cluster on it with one command. It requires blablabla...Proposed changes
List main as well as consequential changes you introduced or had to introduce.
startcommand.setupas prerequisite tostart.Testing
What is the bottom-line functionality that needs testing? Describe in pseudo-code or in English. Use verifiable statements that tie your changes to existing functionality.
startsucceeds first time aftersetupsucceededstartsucceededstartfailedstatusreturns ... ifstartsucceededstatusreturns ... ifstartfailedstartfails afterstartsucceeded or afterstatussays CRC isRunning