shell_windows: Detect shell under ssh

[albfan]

Fixes: Issue #3582

Solution/Idea

$env:SHELL not empty is not definitive to detect shell terminal

Proposed changes

Reuse our logic to detect powershell if current result is not definitive.

Testing

Use crc oc-env under ssh on windows

fixes #3582

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[praveenkumar]

Check praveenkumar@1efb9fa one I think it would be more clear and we don't have to pass the process pid to helper function.

[albfan]

Many thanks for review Praveen.

Just to avoid go into further check, I added a default result to identify non detected shell

[praveenkumar]

Looks like CI is failing because of fmt error run make fmt .

[openshift-ci]

@albfan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-crc	8c30366	link	true	/test integration-crc
ci/prow/e2e-crc	8c30366	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[albfan]

@praveenkumar should be fixed now. I find with goimports but not sure where CI show that error