Use a config file format like ssh's #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parser returns a HostConfiguration struct, which is a figment::Provider - make it clear that you can only use Parser once - extract arbitrary types from ssh config files - Use extract_lossy() to allow strings to coerce to ints and bools - Use figment Profile to specify that this is for a given host - consolidate and deduplicate pretty-printing code in manager - provide config source information - improve config error output - add a newtype wrapper for figment::Error with custom Display - custom display for figment::error::Kind - split up ssh.rs into component parts for readability
- merge Manager::default and Manager::empty - rename Manager::new -> standard - hide Manager::without_files() behind cfg(test)
…-host settings only
…Host - Update error message output to suit - --show-config outputs settings for the job where possible - This overhauled DisplayAdapter::fmt() - Tweak source display for values read from files - add cli_beats_config_file test - remove toml scaffolding - update config module docs for file format
- AddressFamily - - rename enum variants to Inet / Inet6 / Any - - serialize as "inet4" / "inet6" to align with ssh config - - accept aliases "4" / "6" - - no need to use IntOrString now we've changed config file format - PortRange - - no need to deserialise via IntOrString - - drop From<u64> - - derive Default - HumanU64 - - no need to deserialize from IntOrString - - ser/de as string for now - drop IntOrString as no longer used
crazyscot
force-pushed
the
feat/ssh-style-config-file
branch
from
77e057e to
ede84b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.