Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv cmd/main.go main.go #43

Closed
wants to merge 1 commit into from
Closed

mv cmd/main.go main.go #43

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 13, 2019

This allows users to use go get -u github.com/ftpgrab/ftpgrab to
install from source more easily. It also let's use package goftp
more easily on FreeBSD and most likely other operating systems.

This allows users to use go get -u github.com/ftpgrab/ftpgrab to
install from source more easily. It also let's use package goftp
more easily on FreeBSD and most likely other operating systems.
@crazy-max
Copy link
Owner

I prefer to keep this project layout to respect standard.
Yeah it's kinda unofficial 🙃 but big go projects in the wild use this nomenclature :

And you can always use go get -u github.com/ftpgrab/ftpgrab/cmd to install from source.

@ghost
Copy link
Author

ghost commented Feb 13, 2019

Did not know that about go get. Totally understand. I'm working on getting it packaged in FreeBSD right now. Keep you posted.

@ghost ghost closed this Feb 13, 2019
@crazy-max
Copy link
Owner

crazy-max commented Feb 13, 2019

@gregf Keep me in touch, I encountered an issue with go get -u, see russross/blackfriday#491

go mod edit -replace=gopkg.in/russross/[email protected]=github.com/russross/blackfriday/[email protected]

Update your PR if you can thanks :)

@crazy-max crazy-max reopened this Feb 13, 2019
@ghost
Copy link
Author

ghost commented Feb 13, 2019

Any chance I can get you to vendor your go mods in a vendor directory? It makes things for my FreeBSD package way simpler to maintain and personally I believe everything should be vendor anyways, I do it in my projects.

@crazy-max
Copy link
Owner

@gregf Since Go 1.11 I prefer to drop vendoring entirely. Please read this official thread about it. You can use go mod vendor to reset the main module's vendor directory to include all packages needed to build if you want or maybe we could create a side repository to put vendoring in it and create a git submodule in this repository but I'm not a huge fan.

@ghost
Copy link
Author

ghost commented Feb 14, 2019

I got the port working finally, I'll link you to the pr tomorrow

@crazy-max
Copy link
Owner

@gregf I close this PR, please open a new one relative to FreeBSD if you want. Thanks!

@crazy-max crazy-max closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant