Use io.Copy to avoid crash due to insufficient memory

crazy-max · Jul 27, 2019 · 1843c79 · 1843c79
1 parent 8a4d41a
commit 1843c79
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.0.2 (2019/07/27)
+
+* Use `io.Copy` to avoid crash due to insufficient memory
+
 ## 6.0.1 (2019/07/24)
 
 * Fix cron stopped after first trigger

diff --git a/internal/server/ftp/client.go b/internal/server/ftp/client.go
@@ -4,7 +4,6 @@ import (
 	"crypto/tls"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"os"
 	"regexp"
 	"time"
@@ -108,12 +107,7 @@ func (c *Client) Retrieve(path string, dest io.Writer) error {
 	}
 	defer resp.Close()
 
-	buf, err := ioutil.ReadAll(resp)
-	if err != nil {
-		return err
-	}
-
-	_, err = dest.Write(buf)
+	_, err = io.Copy(dest, resp)
 	return err
 }