Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark mode 🌑] Add a dark theme? #227

Open
jramsgz opened this issue Jun 10, 2020 · 8 comments · May be fixed by #1280 or invoice-crater/crater#22
Open

[Dark mode 🌑] Add a dark theme? #227

jramsgz opened this issue Jun 10, 2020 · 8 comments · May be fixed by #1280 or invoice-crater/crater#22

Comments

@jramsgz
Copy link
Contributor

jramsgz commented Jun 10, 2020

After using this app I noticed that it lacks the feature of a dark mode and I thought it would be very cool to have one, would you be interested? I can send a PR for that (after 4.0 is released as it has a complete rewrite of the CSS)
Also, where should I store the user settings for dark theme? (Database, local storage, ...)

@mohitpanjwani
Copy link
Contributor

Hi @MakerLab-Dev,

Yes, a dark theme would be really great.. but its a lot of work in terms of design. Are you familiar with Figma?

How are you looking to work on this? will you be creating the design first or directly start working on styles?

@jramsgz
Copy link
Contributor Author

jramsgz commented Jun 19, 2020

I was thinking on using TailwindCSS theme feature, so that all the colors for dark mode can be changed from that file and (I think) that it won't take too much time to implement.
No, I'm not familiar with Figma but I don't think we'll need it as it's just changing colors
Tell me what you think about that and if you think there is another better approach

@jramsgz
Copy link
Contributor Author

jramsgz commented Sep 6, 2020

Quick update here
Looks like a dark mode variant is being developed by tailwind
https://github.com/tailwindlabs/tailwindcss/releases#dark-mode-experimental
I think that we could use that to make the dark mode of crater and be benefited from its simplicity and rapid development
What do you think? @mohitpanjwani

@mohitpanjwani
Copy link
Contributor

Hi @MakerLab-Dev yes that sounds great and its exactly what we were looking at for dark mode.

We can discuss that after this update is deployed :)

@azaricstefan
Copy link
Contributor

Great idea for the Dark mode!
It should be easy to switch to dark mode now that there is tailwind in v4.

@root9191
Copy link

would also love a dark theme here

@flamekiller22
Copy link

What's the progress like at the moment? Been quite a while now.

@Madgique
Copy link

is the dark mode enabled so ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants