Types: Add support for CrateDB's FLOAT_VECTOR data type and KNN_MATCH function
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
FLOAT_VECTOR data typeFLOAT_VECTOR data type
amotl
force-pushed
the
amo/type-float-vector
branch
from
a232609
to
c8305b1
Compare
amotl
changed the title
FLOAT_VECTOR data typeFLOAT_VECTOR data type: FloatVector
amotl
force-pushed
the
amo/type-float-vector
branch
4 times, most recently
from
264f370
to
b2ef319
Compare
amotl
force-pushed
the
refactor-types
branch
from
c5a4020
to
1da3eb2
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
2 times, most recently
from
99a0e3a
to
56bd4b6
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
from
56bd4b6
to
1070b37
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
from
1070b37
to
5ddc8e1
Compare
amotl
changed the title
FLOAT_VECTOR data type: FloatVectorFLOAT_VECTOR data type: FloatVector
1 task
amotl
force-pushed
the
amo/type-float-vector
branch
from
5ddc8e1
to
9c550d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 84.65% 85.74% +1.08%
==========================================
Files 14 15 +1
Lines 919 989 +70
==========================================
+ Hits 778 848 +70
Misses 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amotl
force-pushed
the
amo/type-float-vector
branch
3 times, most recently
from
38e8eee
to
fd12f98
Compare
amotl
commented
Jun 8, 2024
amotl
force-pushed
the
amo/type-float-vector
branch
2 times, most recently
from
ba973a9
to
b2f448f
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
3 times, most recently
from
921aefa
to
ff7c081
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
from
ff7c081
to
79538f8
Compare
amotl
changed the title
FLOAT_VECTOR data type: FloatVectorFLOAT_VECTOR data type and KNN_MATCH function
amotl
force-pushed
the
amo/type-float-vector
branch
2 times, most recently
from
ca317f8
to
4a4ceb4
Compare
surister
reviewed
Jun 10, 2024
surister
approved these changes
Jun 10, 2024
amotl
force-pushed
the
amo/type-float-vector
branch
3 times, most recently
from
0f85790
to
20443d2
Compare
amotl
force-pushed
the
amo/type-float-vector
branch
from
20443d2
to
9557d1c
Compare
The `all` extra bundles all optional dependencies, like, in this case, `numpy`, added to support the `FLOAT_VECTOR` data type.
We don't know which circumstances cause this problem. SQLAlchemy 1.3 is
EOL anyway, so we don't care too much.
sqlalchemy.exc.InvalidRequestError: When initializing mapper mapped class RootStore->root, expression 'ItemStore' failed to locate a name ('ItemStore'). If this is a class name, consider adding this relationship() to the <class 'tests.compiler_test.SqlAlchemyDDLCompilerTest.test_ddl_with_foreign_keys.<locals>.RootStore'> class after both dependent classes have been defined.
amotl
force-pushed
the
amo/type-float-vector
branch
from
9557d1c
to
36d8b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
CrateDB's
FLOAT_VECTORdata type, and its accompanyingKNN_MATCHfunction, have been added with CrateDB 5.5.0. This patch adds corresponding SQLAlchemy type and function/predicate support.Details
Those two implementetations have been predecessors, and both sites will be used to verify this patch, after it has been merged.
Backlog