Dependencies: Update to lorrystream 0.0.4 and commons-codec 0.0.6. Adjust code. Add software tests. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
requested review from
hammerhead,
surister,
hlcianfagna and
wierdvanderhaar
and removed request for
surister and
wierdvanderhaar
On the last occasion, dependencies to lorrystream have not been verified correctly, so it was expectable that things go south. This patch fixes them, and adds rudimentary software tests to avoid tripping into the same situation as before.
amotl
force-pushed
the
fix-lorry-2
branch
2 times, most recently
from
564a668 to
ad344d2
Compare
hlcianfagna
reviewed
Aug 16, 2024
There was a problem hiding this comment.
This builds and now I can succesfully
from cratedb_toolkit.iac.aws import DynamoDBKinesisPipe, LambdaFactory, LambdaPythonImagebut I cannot use the new commons-codec with it
lorrystream 0.0.3 requires commons-codec==0.0.3, but you have commons-codec 0.0.5 which is incompatible
|
Thanks for reporting. It is probably similar to that spot reported by CI: That other patch relaxes dependency constraints a bit. It will hopefully improve situations like that. |
amotl
changed the title
amotl
force-pushed
the
fix-lorry-2
branch
2 times, most recently
from
3ed3552 to
794b832
Compare
It provides some woes around the `multiprocess` package, becoming apparent when building the OCI image. So, let's just not include it into the standard OCI release package for now.
The admonition raised by GHA check warnings is: > Legacy key/value format with whitespace separator should not be used > > LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy > "ENV key value" format > More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On the last occasion, dependencies to lorrystream have not been verified correctly, so it was expectable that things go south at some point. Pinning to a branch, or pinning to a specific commit, are both not satisfying solutions to compensate properly for aligning things that are in flux by nature. C'est la vie.
Solution
This patch fixes them, and adds rudimentary software tests to avoid tripping into the same situation as before.
References
/cc @wierdvanderhaar, @surister, @ckurze