Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Clean up and refactor SQLAlchemy polyfills #186

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 6, 2024

... to cratedb_toolkit.util.

@amotl amotl force-pushed the amo/sa-refactor-patches branch from cd23a66 to 06ea9a7 Compare July 6, 2024 18:58
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (19c5cff) to head (a9192f7).

❗ There is a different number of reports uploaded between BASE (19c5cff) and HEAD (a9192f7). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (19c5cff) HEAD (a9192f7)
influxdb 4 0
mongodb 10 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   82.01%   72.04%   -9.97%     
==========================================
  Files          81       79       -2     
  Lines        3247     3209      -38     
==========================================
- Hits         2663     2312     -351     
- Misses        584      897     +313     
Flag Coverage Δ
influxdb ?
main 59.98% <50.00%> (-0.47%) ⬇️
mongodb ?
pymongo 42.34% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the amo/sa-refactor-patches branch from 06ea9a7 to a9192f7 Compare July 6, 2024 19:09
... to `cratedb_toolkit.util.sqlalchemy`.
@amotl amotl force-pushed the amo/sa-refactor-patches branch from a9192f7 to 551c2e7 Compare July 6, 2024 19:21
@amotl amotl marked this pull request as ready for review July 6, 2024 19:21
@amotl amotl merged commit a654983 into main Jul 6, 2024
5 of 6 checks passed
@amotl amotl deleted the amo/sa-refactor-patches branch July 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant