Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO: Add the if-exists query parameter by updating to influxio 0.4.0 #176

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 23, 2024

Problem

Because the InfluxDB I/O subsystem, implementing ctk load table influxdb2://..., always replaced the target table, it could have been considered as "just a toy". Thanks to that discovery by @wierdvanderhaar, we have been able to improve it.

Solution

The improvement follows the semantics of the to_sql() implementation of pandas/Dask, and now takes a new if-exists URL query parameter into consideration, forwarding the possible values {fail,replace,append} to the corresponding implementation.

References

/cc @matkuliak, @simonprickett

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (783313a) to head (849c007).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files          68       68           
  Lines        2716     2716           
=======================================
  Hits         2193     2193           
  Misses        523      523           
Flag Coverage Δ
influxdb 36.63% <ø> (ø)
main 68.33% <ø> (ø)
mongodb 46.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl marked this pull request as ready for review June 23, 2024 14:49
@amotl amotl force-pushed the amo/influxio-if-exists branch from f9e2809 to 849c007 Compare June 24, 2024 08:03
@amotl amotl merged commit 4797dda into main Jun 24, 2024
21 checks passed
@amotl amotl deleted the amo/influxio-if-exists branch June 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants