Dependencies: Migrate from crate[sqlalchemy] to sqlalchemy-cratedb
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
===========================================
+ Coverage 52.10% 79.01% +26.90%
===========================================
Files 56 56
Lines 1969 1973 +4
===========================================
+ Hits 1026 1559 +533
+ Misses 943 414 -529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
force-pushed
the
sqlalchemy-nt
branch
7 times, most recently
from
f1ee2e3 to
e6e3f13
Compare
amotl
commented
Jun 11, 2024
pyproject.toml
Outdated
| "crate[sqlalchemy]>=0.34", | ||
| "crate @ git+https://github.com/crate/crate-python.git@no-sqlalchemy", |
There was a problem hiding this comment.
The crate package will probably need to be published before being able to conclude the migration. For example, let's use/ focus on crate[sqlalchemy].
amotl
force-pushed
the
sqlalchemy-nt
branch
2 times, most recently
from
429ddab to
2fba43b
Compare
The CrateDB SQLAlchemy dialect needs more love, so it was separated from the DBAPI HTTP driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The CrateDB SQLAlchemy dialect needs more love, so it was separated from the DBAPI HTTP driver. This patch verifies and concludes the migration.
References