Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Export cratedb_service fixture as pytest11 entrypoint #113

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 9, 2024

About

@surister discovered that the package did not export the cratedb_service fixture as pytest11 entrypoint. Thanks!

Details

This way, for basic needs, corresponding boilerplate code does not need to be provided by downstream projects.

When needing more configurability, you will need to define corresponding alternative fixtures, and not use the built-in provided from.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3a8e9bf) 84.82% compared to head (93252b5) 78.63%.

Files Patch % Lines
cratedb_toolkit/testing/pytest.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   84.82%   78.63%   -6.19%     
==========================================
  Files          48       49       +1     
  Lines        1812     1821       +9     
==========================================
- Hits         1537     1432     -105     
- Misses        275      389     +114     
Flag Coverage Δ
influxdb 35.09% <0.00%> (-6.25%) ⬇️
main 60.46% <0.00%> (-6.38%) ⬇️
mongodb 49.86% <0.00%> (-6.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl requested a review from surister February 9, 2024 21:41
@amotl amotl marked this pull request as ready for review February 9, 2024 21:41
@amotl amotl force-pushed the amo/pytest11 branch 2 times, most recently from f56f85e to 3f73bde Compare February 9, 2024 22:01
amotl added 2 commits February 9, 2024 23:26
This way, for basic needs, corresponding boilerplate code does not need
to be provided by downstream projects.

When needing more configurability, you will need to define corresponding
alternative fixtures, and not use the built-in provided from.
@amotl amotl merged commit d8b0699 into main Feb 9, 2024
20 checks passed
@amotl amotl deleted the amo/pytest11 branch February 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant