Tests: Use small timeouts for server selection tests in http.txt
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/improve-http-doctest-timing
branch
from
d894298
to
b647ea0
Compare
|
#630 happens on this as well. Sigh. -- https://github.com/crate/crate-python/actions/runs/3218108206/jobs/5261874131#step:4:381 |
amotl
changed the title
http.txthttp.txt
amotl
force-pushed
the
amo/improve-http-doctest-timing
branch
from
b647ea0
to
7b9ebd0
Compare
amotl
force-pushed
the
amo/improve-http-doctest-timing
branch
from
7b9ebd0
to
6120cc1
Compare
|
I think this change is reasonable, and can be merged. |
amotl
changed the title
http.txthttp.txt
kneth
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Sebastian,
this patch is based on the commit 575f6a3 you submitted the other day with #431. I would like to investigate if it might improve timing behaviour/flakyness on CI, as documented at #404.
With kind regards,
Andreas.