Add compatibility for PHP8 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/php8
branch
2 times, most recently
from
d354a02 to
e188f32
Compare
amotl
force-pushed
the
amo/php8
branch
2 times, most recently
from
71f5c13 to
43b04c2
Compare
amotl
force-pushed
the
amo/php8
branch
7 times, most recently
from
12fbe26 to
e8d8b99
Compare
We found that Coveralls is not able to merge coverage reports from different job runs. Since supporting PHP8, we have different code branches in order to support the old and the new PDO interface. So, it is crucial to merge coverage reports from two job runs, one for PHP7.4 and another for PHP8.
This will aid on running the tests with coverage on both PHP7 and PHP8, merge coverage reports and render them as HTML to be inspected by humans. It's not completely maintenance free because some paths will probably have to be adjusted for others, but it's way better than nothing.
With the introduction of PHP8 compatibility, some `class_alias` code has been introduced. We have not been able to make PHPUnit grok the coverage of this code by other means. Additionally, some annotations have been added to improve code coverage metrics on code which actually has been covered but was not accounted.
amotl
commented
Feb 25, 2021
Comment on lines
+42
to
+45
| if ($fetchMode !== null) { | ||
| throw new UnsupportedException('PDO::query $fetchMode not implemented yet'); | ||
| } | ||
| // FIXME: return $this->doQuery($query, $fetchMode, ...$fetchModeArgs); |
There was a problem hiding this comment.
With the updates to the PHP PDO interface, query() operations using fetch styles/modes are now possible directly on the main PDO object reference. In earlier versions, a PDOStatement was needed for that.
While this patch already brings in PHP8 compatibility in general, this specific detail has not been implemented yet and has to be eventually followed up on, see #117.
seut
reviewed
Feb 25, 2021
amotl
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
PHP 8.0.2 has been released and PHP 8.1.x is in the making. This addresses #115 by adding compatibility for PHP8.0 and deprecating support for PHP7.2, which reached end of life. At the same time, we upgraded to PHPUnit 9.x.
Because PHP's PDO interface has changed, we tried to align to what Doctrine and Drupal were doing to be compatible with both PHP7 and PHP8.
Reason:
Implementation derived and inspired from:
With kind regards,
Andreas.