CrateDB vector: Add CrateDBVectorSearchMultiCollection
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
requested review from
hammerhead,
matriv,
andnig and
mkleen
and removed request for
hammerhead
amotl
force-pushed
the
multicollection-search
branch
2 times, most recently
from
51ec5a2
to
e99f9f4
Compare
matriv
reviewed
Nov 21, 2023
matriv
reviewed
Nov 21, 2023
amotl
force-pushed
the
multicollection-search
branch
from
db272af
to
7aeedff
Compare
matriv
approved these changes
Nov 21, 2023
| @@ -367,11 +364,12 @@ def test_cratedb_collection_with_metadata() -> None: | |||
|
|
|||
|
|
|||
| def test_cratedb_collection_no_embedding_dimension() -> None: | |||
| """Test end to end collection construction""" | |||
| """ | |||
| Verify that accessing a collection fails when addressed without dimensionality. | |||
There was a problem hiding this comment.
Suggested change
| Verify that accessing a collection fails when addressed without dimensionality. | |
| Verify that accessing a collection fails when addressed without specifying dimensios. |
There was a problem hiding this comment.
Thanks. Addressed by amending 153d178280c7:
Verify that addressing collections fails when not specifying dimensions.
amotl
force-pushed
the
multicollection-search
branch
2 times, most recently
from
153d178
to
84161f7
Compare
amotl
force-pushed
the
fix-cascaded-delete
branch
from
9e6e799
to
e32a572
Compare
It is a special adapter which provides similarity search across multiple collections. It can not be used for indexing documents.
The CrateDB adapter works a bit different compared to the pgvector adapter it is building upon: Because the dimensionality of the vector field needs to be specified at table creation time, but because it is also a runtime parameter in LangChain, the table creation needs to be delayed. In some cases, the tables do not exist yet, but this is only relevant for the case when the user requests to pre-delete the collection, using the `pre_delete_collection` argument. So, do the error handling only there instead, and _not_ on the generic data model utility functions.
amotl
force-pushed
the
multicollection-search
branch
from
84161f7
to
d8ecebe
Compare
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
It is a special adapter which provides similarity search across multiple collections. It can not be used for indexing documents.
Synopsis
References
This patch has been conceived based on a feature request by @thunderbug1. Thanks!