fix(config): Propagate validation errors #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `flatten`ing an `Option`, all errors are silenced, making the value `None`, not just "this field doesn't exist". The easiest way around this was to not use `Option`. Not too confident in all of the changes but tests pass? Fixes crate-ci#881
|
Wonderful! Thanks for the quick fix :) |
epage
added a commit
to epage/typos
that referenced
this pull request
Aug 22, 2024
This was broken in crate-ci#882
epage
added a commit
to epage/typos
that referenced
this pull request
Aug 22, 2024
This was broken in crate-ci#882
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
flattening anOption, all errors are silenced, making the valueNone, not just "this field doesn't exist".The easiest way around this was to not use
Option.Not too confident in all of the changes but tests pass?
Fixes #881