Replaced deprecated cargo --all flag with --workspace flag
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I suppose this should be parametrized on the Rust version? Otherwise old Rust versions won't work. Otherwise looks okay to me. |
epage
reviewed
Dec 4, 2019
| displayName: Check compilation w/ default features | ||
| - script: cargo check --all --bins --examples --tests --no-default-features |
There was a problem hiding this comment.
What about for crates where --all evaluates to one crate?
epage
reviewed
Dec 4, 2019
| @@ -29,14 +29,12 @@ jobs: | |||
| - script: cargo check --locked | |||
| condition: and(succeeded(), eq(variables.is_locked, 'true')) | |||
| displayName: Check that Cargo.lock is satisfiable | |||
| - script: cargo check --all --bins --examples --tests | |||
| - script: cargo check --workspace --bins --examples --tests | |||
There was a problem hiding this comment.
As djc mentioned, we support pinning to older Rust versions, particularly for MSRV validation. I think the simpler approach is for us to keep using --all until either they plan to remove it or until the Rust version is so old we don't care about supporting it still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo check -h shows that the --all flag has been depreacated and replaced with the --workspace flag. Also rust-lang/cargo#5015 shows hat the --no-default-features is currently broken so we thought that this part of the pipeline should be deleted (at least until this gets fixed) from the
cargo-check.ymlfile.